refactor: add default min row height to dashboard#8099
Merged
tomivirkki merged 2 commits intomainfrom Nov 8, 2024
Merged
Conversation
tomivirkki
force-pushed
the
refactor/dashboard-default-min-row-height
branch
from
fd0cc9d to
9aa2f06
Compare
ugur-vaadin
reviewed
Nov 8, 2024
packages/dashboard/test/helpers.ts
Outdated
| if (height === undefined) { | ||
| dashboard.style.setProperty('--vaadin-dashboard-row-min-height', 'auto'); | ||
| } else { | ||
| dashboard.style.setProperty('--vaadin-dashboard-row-min-height', height !== undefined ? `${height}px` : null); |
Contributor
There was a problem hiding this comment.
This is always true.
Suggested change
| dashboard.style.setProperty('--vaadin-dashboard-row-min-height', height !== undefined ? `${height}px` : null); | |
| dashboard.style.setProperty('--vaadin-dashboard-row-min-height', `${height}px`); |
Member
Author
There was a problem hiding this comment.
True, cleaned up the helper
ugur-vaadin
approved these changes
Nov 8, 2024
Contributor
ugur-vaadin
left a comment
ugur-vaadin
left a comment
There was a problem hiding this comment.
Added one suggestion for the helper.
|
Collaborator
|
This ticket/PR has been released with Vaadin 24.6.0.alpha3 and is also targeting the upcoming stable 24.6.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add default min row height (12rem) to dashboard layout.
This will also enable vertical resizing of widgets by default.
Type of change
Refactor/feature